Commit 288c8b5b authored Sep 07, 2021 by Nanyong Sun Committed by Greg Kroah-Hartman Sep 26, 2021

nilfs2: fix memory leak in nilfs_sysfs_create_##name##_group

[ Upstream commit 24f8cb1ed057c840728167dab33b32e44147c86f ]

If kobject_init_and_add return with error, kobject_put() is needed here to
avoid memory leak, because kobject_init_and_add may return error without
freeing the memory associated with the kobject it allocated.

Link: https://lkml.kernel.org/r/20210629022556.3985106-4-sunnanyong@huawei.com
Link: https://lkml.kernel.org/r/1625651306-10829-4-git-send-email-konishi.ryusuke@gmail.com


Signed-off-by: Nanyong Sun <sunnanyong@huawei.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent dc70f0c8

fs/nilfs2/sysfs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -92,8 +92,8 @@ static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
		err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \
		#name); \
		if (err) \
		kobject_put(kobj); \
		return err; \
		return 0; \
		} \
		static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
		{ \