Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 282d1056 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Simplify a debug statement 



Read the FC port state once instead of twice. This patch fixes the
following Coverity complaint:

Unchecked return value (CHECKED_RETURN)
check_return: Calling atomic_read without checking return value (as is
done elsewhere 80 out of 92 times).

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 258f0752

drivers/scsi/qla2xxx/qla_isr.c

+1 −1
Original line number Diff line number Diff line
@@ -2726,7 +2726,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) 
				"Port to be marked lost on fcport=%02x%02x%02x, current "

				"port state= %s comp_status %x.\n", fcport->d_id.b.domain,

				fcport->d_id.b.area, fcport->d_id.b.al_pa,

				port_state_str[atomic_read(&fcport->state)],

				port_state_str[FCS_ONLINE],

				comp_status);



			qla2x00_mark_device_lost(fcport->vha, fcport, 1, 1);