Commit 28046827 authored Dec 21, 2022 by Christoph Hellwig Committed by Greg Kroah-Hartman Jan 18, 2023

nvme: fix the NVME_CMD_EFFECTS_CSE_MASK definition



[ Upstream commit 685e6311637e46f3212439ce2789f8a300e5050f ]

3 << 16 does not generate the correct mask for bits 16, 17 and 18.
Use the GENMASK macro to generate the correct mask instead.

Fixes: 84fef62d ("nvme: check admin passthru command effects")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 24561f5d

include/linux/nvme.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -7,6 +7,7 @@
		#ifndef _LINUX_NVME_H
		#define _LINUX_NVME_H

		#include <linux/bits.h>
		#include <linux/types.h>
		#include <linux/uuid.h>

		@@ -469,7 +470,7 @@ enum {
		NVME_CMD_EFFECTS_NCC = 1 << 2,
		NVME_CMD_EFFECTS_NIC = 1 << 3,
		NVME_CMD_EFFECTS_CCC = 1 << 4,
		NVME_CMD_EFFECTS_CSE_MASK = 3 << 16,
		NVME_CMD_EFFECTS_CSE_MASK = GENMASK(18, 16),
		NVME_CMD_EFFECTS_UUID_SEL = 1 << 19,
		};