Commit 27fbe64b authored Sep 19, 2014 by Sam Bobroff Committed by Paolo Bonzini Sep 22, 2014

KVM: correct null pid check in kvm_vcpu_yield_to()



Correct a simple mistake of checking the wrong variable
before a dereference, resulting in the dereference not being
properly protected by rcu_dereference().

Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 85c8555f

virt/kvm/kvm_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1725,7 +1725,7 @@ int kvm_vcpu_yield_to(struct kvm_vcpu *target)
		rcu_read_lock();
		pid = rcu_dereference(target->pid);
		if (pid)
		task = get_pid_task(target->pid, PIDTYPE_PID);
		task = get_pid_task(pid, PIDTYPE_PID);
		rcu_read_unlock();
		if (!task)
		return ret;