Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27f712cd authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Greg Kroah-Hartman
Browse files

mmc: sdhci-pci: Fix possible memory leak caused by missing pci_dev_put() 



commit 222cfa0118aa68687ace74aab8fdf77ce8fbd7e6 upstream.

pci_get_device() will increase the reference count for the returned
pci_dev. We need to use pci_dev_put() to decrease the reference count
before amd_probe() returns. There is no problem for the 'smbus_dev ==
NULL' branch because pci_dev_put() can also handle the NULL input
parameter case.

Fixes: 659c9bc1 ("mmc: sdhci-pci: Build o2micro support in the same module")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221114083100.149200-1-wangxiongfeng2@huawei.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 616c6695

drivers/mmc/host/sdhci-pci-core.c

+2 −0
Original line number Diff line number Diff line
@@ -1795,6 +1795,8 @@ static int amd_probe(struct sdhci_pci_chip *chip) 
		}

	}



	pci_dev_put(smbus_dev);



	if (gen == AMD_CHIPSET_BEFORE_ML || gen == AMD_CHIPSET_CZ)

		chip->quirks2 |= SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD;