Commit 27911977 authored Jun 05, 2013 by Christopher Harvey Committed by Dave Airlie Jun 17, 2013

drm/mgag200: Don't do full cleanup if mgag200_device_init fails



Running mgag200_driver_unload when the driver init fails early on
causes functions like drm_mode_config_cleanup to be called. The
problem is, drm_mode_config_cleanup crashes because the corresponding
init hasn't happend yet. There really isn't anything to cleanup after
mgag200_device_init, so we can just pass the error code upwards.

Acked-by: Julia Lemire <jlemire@matrox.com>
Signed-off-by: Christopher Harvey <charvey@matrox.com>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: Dave Airlie <airlied@gmail.com>

parent a080db9f

drivers/gpu/drm/mgag200/mgag200_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags)
		r = mgag200_device_init(dev, flags);
		if (r) {
		dev_err(&dev->pdev->dev, "Fatal error during GPU init: %d\n", r);
		goto out;
		return r;
		}
		r = mgag200_mm_init(mdev);
		if (r)