Commit 274052ef authored Dec 13, 2010 by Dr. David Alan Gilbert Committed by Al Viro Jan 17, 2011

hpfs_setattr error case avoids unlock_kernel

This fixed a case that 'sparse' spotted where hpfs_setattr has an error return
that didn't go through it's path that unlocks.

This is against git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git


version 6313e3c2.

Build tested only, I don't have an hpfs file system to test.

Dave

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent e0bb6bda

fs/hpfs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -281,7 +281,7 @@ int hpfs_setattr(struct dentry dentry, struct iattr attr)
		attr->ia_size != i_size_read(inode)) {
		error = vmtruncate(inode, attr->ia_size);
		if (error)
		return error;
		goto out_unlock;
		}

		setattr_copy(inode, attr);