Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26f55b60 authored by Li Zhijian's avatar Li Zhijian Committed by Greg Kroah-Hartman
Browse files

selftests/bpf: Enlarge select() timeout for test_maps



[ Upstream commit 2d82d73da35b72b53fe0d96350a2b8d929d07e42 ]

0Day robot observed that it's easily timeout on a heavy load host.
-------------------
 # selftests: bpf: test_maps
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 1024 tasks to 'test_update_delete'
 # Fork 100 tasks to 'test_hashmap'
 # Fork 100 tasks to 'test_hashmap_percpu'
 # Fork 100 tasks to 'test_hashmap_sizes'
 # Fork 100 tasks to 'test_hashmap_walk'
 # Fork 100 tasks to 'test_arraymap'
 # Fork 100 tasks to 'test_arraymap_percpu'
 # Failed sockmap unexpected timeout
 not ok 3 selftests: bpf: test_maps # exit=1
 # selftests: bpf: test_lru_map
 # nr_cpus:8
-------------------
Since this test will be scheduled by 0Day to a random host that could have
only a few cpus(2-8), enlarge the timeout to avoid a false NG report.

In practice, i tried to pin it to only one cpu by 'taskset 0x01 ./test_maps',
and knew 10S is likely enough, but i still perfer to a larger value 30.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarLi Zhijian <lizhijian@cn.fujitsu.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/20210820015556.23276-2-lizhijian@cn.fujitsu.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 48f5a5f0
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -972,7 +972,7 @@ static void test_sockmap(unsigned int tasks, void *data)


		FD_ZERO(&w);
		FD_ZERO(&w);
		FD_SET(sfd[3], &w);
		FD_SET(sfd[3], &w);
		to.tv_sec = 1;
		to.tv_sec = 30;
		to.tv_usec = 0;
		to.tv_usec = 0;
		s = select(sfd[3] + 1, &w, NULL, NULL, &to);
		s = select(sfd[3] + 1, &w, NULL, NULL, &to);
		if (s == -1) {
		if (s == -1) {