Commit 26f19c2e authored May 20, 2019 by Adrian Hunter Committed by Arnaldo Carvalho de Melo May 28, 2019

perf intel-pt: Fix itrace defaults for perf script



Commit 4eb06815 ("perf script: Make itrace script default to all
calls") does not work because 'use_browser' is being used to determine
whether to default to periodic sampling (i.e. better for perf report).
The result is that nothing but CBR events display for perf script when
no --itrace option is specified.

Fix by using 'default_no_sample' and 'inject' instead.

Example:

 Before:

  $ perf record -e intel_pt/cyc/u ls
  $ perf script > cmp1.txt
  $ perf script --itrace=cepwx > cmp2.txt
  $ diff -sq cmp1.txt cmp2.txt
  Files cmp1.txt and cmp2.txt differ

 After:

  $ perf script > cmp1.txt
  $ perf script --itrace=cepwx > cmp2.txt
  $ diff -sq cmp1.txt cmp2.txt
  Files cmp1.txt and cmp2.txt are identical

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org # v4.20+
Fixes: 90e457f7 ("perf tools: Add Intel PT support")
Link: http://lkml.kernel.org/r/20190520113728.14389-2-adrian.hunter@intel.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent a685c7a4

tools/perf/util/intel-pt.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2588,7 +2588,8 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
		} else {
		itrace_synth_opts__set_default(&pt->synth_opts,
		session->itrace_synth_opts->default_no_sample);
		if (use_browser != -1) {
		if (!session->itrace_synth_opts->default_no_sample &&
		!session->itrace_synth_opts->inject) {
		pt->synth_opts.branches = false;
		pt->synth_opts.callchain = true;
		}