Commit 26e7c965 authored Sep 24, 2022 by Darrick J. Wong Committed by Greg Kroah-Hartman Sep 28, 2022

xfs: fix use-after-free when aborting corrupt attr inactivation



commit 496b9bcd62b0b3a160be61e3265a086f97adcbd3 upstream.

Log the corrupt buffer before we release the buffer.

Fixes: a5155b870d687 ("xfs: always log corruption errors")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8b3c9eb1

fs/xfs/xfs_attr_inactive.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,8 +209,8 @@ xfs_attr3_node_inactive(
		* Since this code is recursive (gasp!) we must protect ourselves.
		*/
		if (level > XFS_DA_NODE_MAXDEPTH) {
		xfs_trans_brelse(trans, bp); / no locks for later trans */
		xfs_buf_corruption_error(bp);
		xfs_trans_brelse(trans, bp); / no locks for later trans */
		return -EFSCORRUPTED;
		}