Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26c176ce authored by Zheng Wang's avatar Zheng Wang Committed by Greg Kroah-Hartman
Browse files

hwmon: (xgene) Fix use after free bug in xgene_hwmon_remove due to race condition 



[ Upstream commit cb090e64cf25602b9adaf32d5dfc9c8bec493cd1 ]

In xgene_hwmon_probe, &ctx->workq is bound with xgene_hwmon_evt_work.
Then it will be started.

If we remove the driver which will call xgene_hwmon_remove to clean up,
there may be unfinished work.

The possible sequence is as follows:

Fix it by finishing the work before cleanup in xgene_hwmon_remove.

CPU0                  CPU1

                    |xgene_hwmon_evt_work
xgene_hwmon_remove   |
kfifo_free(&ctx->async_msg_fifo);|
                    |
                    |kfifo_out_spinlocked
                    |//use &ctx->async_msg_fifo
Fixes: 2ca492e2 ("hwmon: (xgene) Fix crash when alarm occurs before driver probe")
Signed-off-by: default avatarZheng Wang <zyytlz.wz@163.com>
Link: https://lore.kernel.org/r/20230310084007.1403388-1-zyytlz.wz@163.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 13efd488

drivers/hwmon/xgene-hwmon.c

+1 −0
Original line number Diff line number Diff line
@@ -768,6 +768,7 @@ static int xgene_hwmon_remove(struct platform_device *pdev) 
{

	struct xgene_hwmon_dev *ctx = platform_get_drvdata(pdev);



	cancel_work_sync(&ctx->workq);

	hwmon_device_unregister(ctx->hwmon_dev);

	kfifo_free(&ctx->async_msg_fifo);

	if (acpi_disabled)