Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 268a351d authored by Vlad Buslov's avatar Vlad Buslov Committed by David S. Miller
Browse files

net: sched: fix typo in walker_check_empty() 



Function walker_check_empty() incorrectly verifies that tp pointer is not
NULL, instead of actual filter pointer. Fix conditional to check the right
pointer. Adjust filter pointer naming accordingly to other cls API
functions.

Fixes: 6676d5e4 ("net: sched: set dedicated tcf_walker flag when tp is empty")
Signed-off-by: default avatarVlad Buslov <vladbu@mellanox.com>
Reported-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 24ed4900

net/sched/cls_api.c

+2 −2
Original line number Diff line number Diff line
@@ -238,10 +238,10 @@ static void tcf_proto_put(struct tcf_proto *tp, bool rtnl_held, 
		tcf_proto_destroy(tp, rtnl_held, extack);

}



static int walker_check_empty(struct tcf_proto *tp, void *d,

static int walker_check_empty(struct tcf_proto *tp, void *fh,

			      struct tcf_walker *arg)

{

	if (tp) {

	if (fh) {

		arg->nonempty = true;

		return -1;

	}