Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2649939a authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: ccg: fix memory leak in do_flash 



In case memory resources for *fw* were successfully allocated,
release them before return.

Addresses-Coverity-ID: 1445499 ("Resource leak")
Fixes: 5c9ae5a8 ("usb: typec: ucsi: ccg: add firmware flashing support")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f2c7c76c

drivers/usb/typec/ucsi/ucsi_ccg.c

+4 −2
Original line number Diff line number Diff line
@@ -862,8 +862,10 @@ static int do_flash(struct ucsi_ccg *uc, enum enum_flash_mode mode) 


not_signed_fw:

	wr_buf = kzalloc(CCG4_ROW_SIZE + 4, GFP_KERNEL);

	if (!wr_buf)

		return -ENOMEM;

	if (!wr_buf) {

		err = -ENOMEM;

		goto release_fw;

	}



	err = ccg_cmd_enter_flashing(uc);

	if (err)