Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 263d21cd authored by Philippe Schenker's avatar Philippe Schenker Committed by Jonathan Cameron
Browse files

iio: stmpe-adc: Reinit completion struct on begin conversion 



In some cases, the wait_completion got interrupted. This caused the
error-handling to mutex_unlock the function. The before turned on
interrupt then got called anyway. In the ISR then completion() was
called causing wrong adc-values returned in a following adc-readout.

Reinitialise completion struct to make sure the counter is zero
when beginning a new adc-conversion.

Signed-off-by: default avatarPhilippe Schenker <philippe.schenker@toradex.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 2abd2937

drivers/iio/adc/stmpe-adc.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -65,6 +65,8 @@ static int stmpe_read_voltage(struct stmpe_adc *info, 




	mutex_lock(&info->lock);

	mutex_lock(&info->lock);





	reinit_completion(&info->completion);



	info->channel = (u8)chan->channel;

	info->channel = (u8)chan->channel;





	if (info->channel > STMPE_ADC_LAST_NR) {

	if (info->channel > STMPE_ADC_LAST_NR) {
@@ -103,6 +105,8 @@ static int stmpe_read_temp(struct stmpe_adc *info, 




	mutex_lock(&info->lock);

	mutex_lock(&info->lock);





	reinit_completion(&info->completion);



	info->channel = (u8)chan->channel;

	info->channel = (u8)chan->channel;





	if (info->channel != STMPE_TEMP_CHANNEL) {

	if (info->channel != STMPE_TEMP_CHANNEL) {