Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2617120f authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: firewire-tascam: handle error code when getting current source of clock 



The return value of snd_tscm_stream_get_clock() is ignored. This commit
checks the value and handle error.

Fixes: e453df44 ("ALSA: firewire-tascam: add PCM functionality")
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20190910135152.29800-2-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2a36c16e

sound/firewire/tascam/tascam-pcm.c

+3 −0
Original line number Diff line number Diff line
@@ -56,6 +56,9 @@ static int pcm_open(struct snd_pcm_substream *substream) 
		goto err_locked;



	err = snd_tscm_stream_get_clock(tscm, &clock);

	if (err < 0)

		goto err_locked;



	if (clock != SND_TSCM_CLOCK_INTERNAL ||

	    amdtp_stream_pcm_running(&tscm->rx_stream) ||

	    amdtp_stream_pcm_running(&tscm->tx_stream)) {