Commit 25e057fd authored May 27, 2015 by Takeshi Yoshimura Committed by Mauro Carvalho Chehab Jun 09, 2015

[media] ddbridge: Do not free_irq() if request_irq() failed



My static checker detected that free_irq() is called even after
request_irq() failed in ddb_probe(). In this case, the kernel may try to
free dev->pdev->irq although the IRQ is not assigned. This event rarely
occurs, but always introduces a warning if it happens.

"goto fail1" always results in disabling enabled MSI and releasing a
requested IRQ. It seems like the former handling is necessary. So I added
a conditional branch before the free_irq() (stat == 0 means request_irq()
succeeds).

Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent ee8defec

drivers/media/pci/ddbridge/ddbridge-core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1630,6 +1630,7 @@ static int ddb_probe(struct pci_dev pdev, const struct pci_device_id id)
		printk(KERN_ERR "fail1\n");
		if (dev->msi)
		pci_disable_msi(dev->pdev);
		if (stat == 0)
		free_irq(dev->pdev->irq, dev);
		fail:
		printk(KERN_ERR "fail\n");