Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 250f3915 authored by NeilBrown's avatar NeilBrown Committed by Linus Torvalds
Browse files

[PATCH] knfsd: fix an NFSD bug with full sized, non-page-aligned reads 



NFSd assumes that largest number of pages that will be needed for a
request+response is 2+N where N pages is the size of the largest permitted
read/write request.  The '2' are 1 for the non-data part of the request, and 1
for the non-data part of the reply.

However, when a read request is not page-aligned, and we choose to use
->sendfile to send it directly from the page cache, we may need N+1 pages to
hold the whole reply.  This can overflow and array and cause an Oops.

This patch increases size of the array for holding pages by one and makes sure
that entry is NULL when it is not in use.

Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1a8eff6d

fs/nfsd/vfs.c

+2 −1
Original line number Diff line number Diff line
@@ -822,6 +822,7 @@ nfsd_read_actor(read_descriptor_t *desc, struct page *page, unsigned long offset 
		rqstp->rq_res.page_len = size;

	} else if (page != pp[-1]) {

		get_page(page);

		if (*pp)

			put_page(*pp);

		*pp = page;

		rqstp->rq_resused++;

include/linux/sunrpc/svc.h

+4 −1
Original line number Diff line number Diff line
@@ -144,8 +144,11 @@ extern u32 svc_max_payload(const struct svc_rqst *rqstp); 
 *

 * Each request/reply pair can have at most one "payload", plus two pages,

 * one for the request, and one for the reply.

 * We using ->sendfile to return read data, we might need one extra page

 * if the request is not page-aligned.  So add another '1'.

 */

#define RPCSVC_MAXPAGES		((RPCSVC_MAXPAYLOAD+PAGE_SIZE-1)/PAGE_SIZE + 2)

#define RPCSVC_MAXPAGES		((RPCSVC_MAXPAYLOAD+PAGE_SIZE-1)/PAGE_SIZE \

				+ 2 + 1)



static inline u32 svc_getnl(struct kvec *iov)

{

net/sunrpc/svcsock.c

+2 −0
Original line number Diff line number Diff line
@@ -1278,6 +1278,8 @@ svc_recv(struct svc_rqst *rqstp, long timeout) 
				schedule_timeout_uninterruptible(msecs_to_jiffies(500));

			rqstp->rq_pages[i] = p;

		}

	rqstp->rq_pages[i++] = NULL; /* this might be seen in nfs_read_actor */

	BUG_ON(pages >= RPCSVC_MAXPAGES);



	/* Make arg->head point to first page and arg->pages point to rest */

	arg = &rqstp->rq_arg;