Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2507abb3 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (pmbus/lm25066) Clamp limit attributes 



Limits on all supported sensors and chips have to be within 0..0x0fff,
and limits are always positive.

Clamp written values in chip driver. Also clear value cache to ensure
that the actually written value is read back and reported correctly.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a7c69118

drivers/hwmon/pmbus/lm25066.c

+13 −0
Original line number Diff line number Diff line
@@ -123,15 +123,28 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg, 
	int ret;



	switch (reg) {

	case PMBUS_VOUT_UV_WARN_LIMIT:

	case PMBUS_OT_FAULT_LIMIT:

	case PMBUS_OT_WARN_LIMIT:

	case PMBUS_VIN_UV_WARN_LIMIT:

	case PMBUS_VIN_OV_WARN_LIMIT:

		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, 0x0fff);

		ret = pmbus_write_word_data(client, 0, reg, word);

		pmbus_clear_cache(client);

		break;

	case PMBUS_IIN_OC_WARN_LIMIT:

		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, 0x0fff);

		ret = pmbus_write_word_data(client, 0,

					    LM25066_MFR_IIN_OC_WARN_LIMIT,

					    word);

		pmbus_clear_cache(client);

		break;

	case PMBUS_PIN_OP_WARN_LIMIT:

		word = ((s16)word < 0) ? 0 : clamp_val(word, 0, 0x0fff);

		ret = pmbus_write_word_data(client, 0,

					    LM25066_MFR_PIN_OP_WARN_LIMIT,

					    word);

		pmbus_clear_cache(client);

		break;

	case PMBUS_VIRT_RESET_PIN_HISTORY:

		ret = pmbus_write_byte(client, 0, LM25066_CLEAR_PIN_PEAK);