Commit 24b6d3ee authored Apr 11, 2018 by Jia-Ju Bai Committed by Greg Kroah-Hartman Apr 23, 2018

misc: ti-st: Replace GFP_ATOMIC with GFP_KERNEL in kim_probe



kim_probe() is never called in atomic context.
This function is only set as ".probe" in struct platform_driver.

Despite never getting called from atomic context,
kim_probe() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c13884a8

drivers/misc/ti-st/st_kim.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -735,7 +735,7 @@ static int kim_probe(struct platform_device *pdev)
		st_kim_devices[0] = pdev;
		}

		kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_ATOMIC);
		kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_KERNEL);
		if (!kim_gdata) {
		pr_err("no mem to allocate");
		return -ENOMEM;