Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24a7cc1e authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum_buffers: Split business logic from mlxsw_sp_port_sb_pms_init() 



The function is used to set the per-port shared buffer quotas.
Currently, these quotas are only set for front panel ports, but a
subsequent patch will configure these quotas for the CPU port as well.

The configuration required for the CPU port is a bit different than that
of the front panel ports, so split the business logic into a separate
function which will be called with different parameters for the CPU
port.

No functional changes intended.

Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Reviewed-by: default avatarPetr Machata <petrm@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 50b5b905

drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c

+14 −7
Original line number Diff line number Diff line
@@ -729,14 +729,13 @@ static const struct mlxsw_sp_sb_pm mlxsw_sp2_sb_pms[] = { 
	MLXSW_SP_SB_PM(0, MLXSW_REG_SBXX_DYN_MAX_BUFF_MIN),

};



static int mlxsw_sp_port_sb_pms_init(struct mlxsw_sp_port *mlxsw_sp_port)

static int mlxsw_sp_sb_pms_init(struct mlxsw_sp *mlxsw_sp, u8 local_port,

				const struct mlxsw_sp_sb_pm *pms)

{

	struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;

	int i;

	int err;

	int i, err;



	for (i = 0; i < mlxsw_sp->sb_vals->pool_count; i++) {

		const struct mlxsw_sp_sb_pm *pm = &mlxsw_sp->sb_vals->pms[i];

		const struct mlxsw_sp_sb_pm *pm = &pms[i];

		u32 max_buff;

		u32 min_buff;
@@ -744,14 +743,22 @@ static int mlxsw_sp_port_sb_pms_init(struct mlxsw_sp_port *mlxsw_sp_port) 
		max_buff = pm->max_buff;

		if (mlxsw_sp_sb_pool_is_static(mlxsw_sp, i))

			max_buff = mlxsw_sp_bytes_cells(mlxsw_sp, max_buff);

		err = mlxsw_sp_sb_pm_write(mlxsw_sp, mlxsw_sp_port->local_port,

					   i, min_buff, max_buff);

		err = mlxsw_sp_sb_pm_write(mlxsw_sp, local_port, i, min_buff,

					   max_buff);

		if (err)

			return err;

	}

	return 0;

}



static int mlxsw_sp_port_sb_pms_init(struct mlxsw_sp_port *mlxsw_sp_port)

{

	struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;



	return mlxsw_sp_sb_pms_init(mlxsw_sp, mlxsw_sp_port->local_port,

				    mlxsw_sp->sb_vals->pms);

}



#define MLXSW_SP_SB_MM(_min_buff, _max_buff)		\

	{						\

		.min_buff = _min_buff,			\