Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 244726ec authored by Luca Coelho's avatar Luca Coelho
Browse files

iwlwifi: mvm: add fall through comments where needed 



Some switch-cases were missing a fall through comment, so the compiler
may warn.  Fix that by adding the comments where needed.  In other
cases there was more text in the comment, which the compiler doesn't
recognize, so either remove the extra text or move it to a separate
comment line as appropriate.

Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 999ced14

drivers/net/wireless/intel/iwlwifi/mvm/led.c

+3 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
 *

 * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved.

 * Copyright(c) 2017        Intel Deutschland GmbH

 * Copyright(c) 2018        Intel Corporation

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of version 2 of the GNU General Public License as
@@ -28,6 +29,7 @@ 
 *

 * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved.

 * Copyright(c) 2017        Intel Deutschland GmbH

 * Copyright(c) 2018        Intel Corporation

 * All rights reserved.

 *

 * Redistribution and use in source and binary forms, with or without
@@ -113,6 +115,7 @@ int iwl_mvm_leds_init(struct iwl_mvm *mvm) 
	switch (mode) {

	case IWL_LED_BLINK:

		IWL_ERR(mvm, "Blink led mode not supported, used default\n");

		/* fall through */

	case IWL_LED_DEFAULT:

	case IWL_LED_RF_STATE:

		mode = IWL_LED_RF_STATE;

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+1 −0
Original line number Diff line number Diff line
@@ -3901,6 +3901,7 @@ static int __iwl_mvm_assign_vif_chanctx(struct iwl_mvm *mvm, 
			mvmvif->ap_ibss_active = true;

			break;

		}

		/* fall through */

	case NL80211_IFTYPE_ADHOC:

		/*

		 * The AP binding flow is handled as part of the start_ap flow

drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c

+1 −0
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ u8 iwl_mvm_get_ctrl_pos(struct cfg80211_chan_def *chandef) 
		return PHY_VHT_CTRL_POS_4_ABOVE;

	default:

		WARN(1, "Invalid channel definition");

		/* fall through */

	case 0:

		/*

		 * The FW is expected to check the control channel position only

drivers/net/wireless/intel/iwlwifi/mvm/rx.c

+1 −1
Original line number Diff line number Diff line
@@ -222,7 +222,7 @@ static u32 iwl_mvm_set_mac80211_rx_flag(struct iwl_mvm *mvm, 
		    !(rx_pkt_status & RX_MPDU_RES_STATUS_TTAK_OK))

			return 0;

		*crypt_len = IEEE80211_TKIP_IV_LEN;

		/* fall through if TTAK OK */

		/* fall through */



	case RX_MPDU_RES_STATUS_SEC_WEP_ENC:

		if (!(rx_pkt_status & RX_MPDU_RES_STATUS_ICV_OK))

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+1 −1
Original line number Diff line number Diff line
@@ -310,7 +310,7 @@ static int iwl_mvm_rx_crypto(struct iwl_mvm *mvm, struct ieee80211_hdr *hdr, 
			stats->flag |= RX_FLAG_MMIC_ERROR;



		*crypt_len = IEEE80211_TKIP_IV_LEN;

		/* fall through if TTAK OK */

		/* fall through */

	case IWL_RX_MPDU_STATUS_SEC_WEP:

		if (!(status & IWL_RX_MPDU_STATUS_ICV_OK))

			return -1;