Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2439d37e authored by Gabriel Fernandez's avatar Gabriel Fernandez Committed by Dmitry Torokhov
Browse files

Input: st-keyscan - fix potential zalloc NULL dereference 



This patch fixes the following static checker warning:

drivers/input/keyboard/st-keyscan.c:156 keyscan_probe()
error: potential zalloc NULL dereference: 'keypad_data->input_dev'

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGabriel Fernandez <gabriel.fernandez@st.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 1cd48dc5

drivers/input/keyboard/st-keyscan.c

+2 −2
Original line number Diff line number Diff line
@@ -153,6 +153,8 @@ static int keyscan_probe(struct platform_device *pdev) 


	input_dev->id.bustype = BUS_HOST;



	keypad_data->input_dev = input_dev;



	error = keypad_matrix_key_parse_dt(keypad_data);

	if (error)

		return error;
@@ -168,8 +170,6 @@ static int keyscan_probe(struct platform_device *pdev) 


	input_set_drvdata(input_dev, keypad_data);



	keypad_data->input_dev = input_dev;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	keypad_data->base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(keypad_data->base))