Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 242501ce authored by Gerard Ryan's avatar Gerard Ryan Committed by Greg Kroah-Hartman
Browse files

Staging: bcm: fix CodingStyle warnings/errors reported by checkpatch.pl in led_control.h



This is a patch to the led_control.h file that fixes numerous warnings
and errors reported by the checkpatch.pl tool. There still remain a few
more, but as this is my first attempt at a commit, I'm not going to be
too adventurous!

Signed-off-by: default avatarGerard Ryan <gerard@ryan.lt>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 07386343
Loading
Loading
Loading
Loading
+36 −38
Original line number Diff line number Diff line
@@ -62,31 +62,29 @@ typedef enum LedEvents {
	LOWPOWER_MODE_ENTER = 0x20,
	IDLEMODE_CONTINUE = 0x40,
	IDLEMODE_EXIT = 0x80,
	LED_THREAD_INACTIVE = 0x100,  //Makes the LED thread Inactivce. It wil be equivallent to putting the thread on hold.
	LED_THREAD_ACTIVE = 0x200    //Makes the LED Thread Active back.
	LED_THREAD_INACTIVE = 0x100,  /* Makes the LED thread Inactivce. It wil be equivallent to putting the thread on hold. */
	LED_THREAD_ACTIVE = 0x200    /* Makes the LED Thread Active back. */
} LedEventInfo_t;	/* Enumerated values of different driver states */

#define DRIVER_HALT 0xff


/*Structure which stores the information of different LED types
 *  and corresponding LED state information of driver states*/
typedef struct LedStateInfo_t
{
/*
 * Structure which stores the information of different LED types
 * and corresponding LED state information of driver states
 */
typedef struct LedStateInfo_t {
	UCHAR LED_Type; /* specify GPIO number - use 0xFF if not used */
	UCHAR LED_On_State; /* Bits set or reset for different states */
	UCHAR LED_Blink_State; /* Bits set or reset for blinking LEDs for different states */
	UCHAR GPIO_Num;
	UCHAR 			BitPolarity;				/*To represent whether H/W is normal polarity or reverse
											  polarity*/
	UCHAR BitPolarity; /* To represent whether H/W is normal polarity or reverse polarity */
} LEDStateInfo, *pLEDStateInfo;


typedef struct _LED_INFO_STRUCT
{
typedef struct _LED_INFO_STRUCT {
	LEDStateInfo	LEDState[NUM_OF_LEDS];
	BOOLEAN 		bIdleMode_tx_from_host; /*Variable to notify whether driver came out
											from idlemode due to Host or target*/
	BOOLEAN		bIdleMode_tx_from_host; /* Variable to notify whether driver came out from idlemode due to Host or target*/
	BOOLEAN			bIdle_led_off;
	wait_queue_head_t   notify_led_event;
	wait_queue_head_t	idleModeSyncEvent;
@@ -95,10 +93,10 @@ typedef struct _LED_INFO_STRUCT
	BOOLEAN			bLedInitDone;

} LED_INFO_STRUCT, *PLED_INFO_STRUCT;
//LED Thread state.
#define BCM_LED_THREAD_DISABLED			 	 0 //LED Thread is not running.
#define BCM_LED_THREAD_RUNNING_ACTIVELY  	 1 //LED thread is running.
#define BCM_LED_THREAD_RUNNING_INACTIVELY	 2 //LED thread has been put on hold
/* LED Thread state. */
#define BCM_LED_THREAD_DISABLED		0 /* LED Thread is not running. */
#define BCM_LED_THREAD_RUNNING_ACTIVELY	1 /* LED thread is running. */
#define BCM_LED_THREAD_RUNNING_INACTIVELY 2 /*LED thread has been put on hold*/