Commit 24208435 authored Oct 25, 2017 by Byungchul Park Committed by Ingo Molnar Oct 25, 2017

locking/lockdep, sched/completions: Change the prefix of lock name for completion variables



CONFIG_LOCKDEP_COMPLETIONS uses "(complete)" as a prefix of lock name
for completion variable.

However, what we should use here is a noun - so use "(completion)" instead.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: amir73il@gmail.com
Cc: axboe@kernel.dk
Cc: darrick.wong@oracle.com
Cc: david@fromorbit.com
Cc: hch@infradead.org
Cc: idryomov@gmail.com
Cc: johan@kernel.org
Cc: johannes.berg@intel.com
Cc: kernel-team@lge.com
Cc: linux-block@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: linux-xfs@vger.kernel.org
Cc: oleg@redhat.com
Cc: tj@kernel.org
Link: http://lkml.kernel.org/r/1508921765-15396-4-git-send-email-byungchul.park@lge.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6f0397d7

include/linux/completion.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -53,7 +53,7 @@ static inline void complete_release_commit(struct completion *x)
		do { \
		static struct lock_class_key __key; \
		lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
		"(complete)" #x, \
		"(completion)" #x, \
		&__key, 0); \
		__init_completion(x); \
		} while (0)
		@@ -67,7 +67,7 @@ static inline void complete_release_commit(struct completion *x) {}
		#ifdef CONFIG_LOCKDEP_COMPLETIONS
		#define COMPLETION_INITIALIZER(work) \
		{ 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
		STATIC_CROSS_LOCKDEP_MAP_INIT("(complete)" #work, &(work)) }
		STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) }
		#else
		#define COMPLETION_INITIALIZER(work) \
		{ 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }