Commit 2414095a authored Sep 23, 2024 by Markus Elfring Committed by Greg Kroah-Hartman Apr 10, 2025

ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()



commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream.

The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.

This issue was detected by using the Coccinelle software.

Fixes: 5648e56d ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a1ef4447

drivers/ntb/test/ntb_perf.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -838,10 +838,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
		dma_set_unmap(tx, unmap);

		ret = dma_submit_error(dmaengine_submit(tx));
		if (ret) {
		dmaengine_unmap_put(unmap);
		if (ret)
		goto err_free_resource;
		}

		dmaengine_unmap_put(unmap);