Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23f5a322 authored by Tomas Winkler's avatar Tomas Winkler Committed by Greg Kroah-Hartman
Browse files

mei: make sure that me_clients_map big enough before copying 



To make static analyzers happy validated that
sizeof me_clients_map  is larger than sizeof valid_addresses from the
enumeration response before memcpy
We can use BUILD_ON macro as both arrays are defined statically

Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent caaeb09a

drivers/misc/mei/hbm.c

+4 −1
Original line number Diff line number Diff line
@@ -673,7 +673,10 @@ void mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr) 


	case HOST_ENUM_RES_CMD:

		enum_res = (struct hbm_host_enum_response *) mei_msg;

		memcpy(dev->me_clients_map, enum_res->valid_addresses, 32);

		BUILD_BUG_ON(sizeof(dev->me_clients_map)

				< sizeof(enum_res->valid_addresses));

		memcpy(dev->me_clients_map, enum_res->valid_addresses,

			sizeof(enum_res->valid_addresses));

		if (dev->dev_state == MEI_DEV_INIT_CLIENTS &&

		    dev->hbm_state == MEI_HBM_ENUM_CLIENTS) {

				dev->init_clients_timer = 0;