Commit 23da547a authored Oct 25, 2019 by Hans de Goede Committed by Greg Kroah-Hartman Dec 17, 2019

tpm: Switch to platform_get_irq_optional()



commit 9c8c5742b6af76a3fd93b4e56d1d981173cf9016 upstream.

platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
tpm_tis driver is optional, this is undesirable.

Specifically this leads to this new false-positive error being logged:
[    5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found

This commit switches to platform_get_irq_optional(), which does not log
an error, fixing this.

Fixes: 7723f4c5 ("driver core: platform: Add an error message to platform_get_irq*()"
Cc: <stable@vger.kernel.org> # 5.4.x
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 12d9c038

drivers/char/tpm/tpm_tis.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -286,7 +286,7 @@ static int tpm_tis_plat_probe(struct platform_device *pdev)
		}
		tpm_info.res = *res;

		tpm_info.irq = platform_get_irq(pdev, 0);
		tpm_info.irq = platform_get_irq_optional(pdev, 0);
		if (tpm_info.irq <= 0) {
		if (pdev != force_pdev)
		tpm_info.irq = -1;