Commit 23ba1997 authored Nov 19, 2022 by YueHaibing Committed by Greg Kroah-Hartman Dec 08, 2022

tipc: check skb_linearize() return value in tipc_disc_rcv()



[ Upstream commit cd0f6421162201e4b22ce757a1966729323185eb ]

If skb_linearize() fails in tipc_disc_rcv(), we need to free the skb instead of
handle it.

Fixes: 25b0b9c4 ("tipc: handle collisions of 32-bit node address hash values")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jon Maloy <jmaloy@redhat.com>
Link: https://lore.kernel.org/r/20221119072832.7896-1-yuehaibing@huawei.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 59f9aad2

net/tipc/discover.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -208,7 +208,10 @@ void tipc_disc_rcv(struct net net, struct sk_buff skb,
		u32 self;
		int err;

		skb_linearize(skb);
		if (skb_linearize(skb)) {
		kfree_skb(skb);
		return;
		}
		hdr = buf_msg(skb);

		if (caps & TIPC_NODE_ID128)