Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2364b6af authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

ACPI: sysfs: validate return type of _STR method 



commit 4bb1e7d027413835b086aed35bc3f0713bc0f72b upstream.

Only buffer objects are valid return values of _STR.

If something else is returned description_show() will access invalid
memory.

Fixes: d1efe3c3 ("ACPI: Add new sysfs interface to export device description")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240709-acpi-sysfs-groups-v2-1-058ab0667fa8@weissschuh.net


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 959974bf

drivers/acpi/device_sysfs.c

+3 −2
Original line number Diff line number Diff line
@@ -533,8 +533,9 @@ int acpi_device_setup_files(struct acpi_device *dev) 
	 * If device has _STR, 'description' file is created

	 */

	if (acpi_has_method(dev->handle, "_STR")) {

		status = acpi_evaluate_object(dev->handle, "_STR",

					NULL, &buffer);

		status = acpi_evaluate_object_typed(dev->handle, "_STR",

						    NULL, &buffer,

						    ACPI_TYPE_BUFFER);

		if (ACPI_FAILURE(status))

			buffer.pointer = NULL;

		dev->pnp.str_obj = buffer.pointer;