Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23189aee authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: serial: keyspan_pda: clean up urb->status usage 



This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.


Cc: <linux-usb-devel@lists.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 95b93454

drivers/usb/serial/keyspan_pda.c

+10 −7
Original line number Original line Diff line number Diff line
@@ -218,11 +218,12 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) 
       	struct tty_struct *tty = port->tty;

       	struct tty_struct *tty = port->tty;

	unsigned char *data = urb->transfer_buffer;

	unsigned char *data = urb->transfer_buffer;

	int i;

	int i;

	int status;

	int retval;

	int status = urb->status;

	struct keyspan_pda_private *priv;

	struct keyspan_pda_private *priv;

	priv = usb_get_serial_port_data(port);

	priv = usb_get_serial_port_data(port);





	switch (urb->status) {

	switch (status) {

	case 0:

	case 0:

		/* success */

		/* success */

		break;

		break;
@@ -230,10 +231,12 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) 
	case -ENOENT:

	case -ENOENT:

	case -ESHUTDOWN:

	case -ESHUTDOWN:

		/* this urb is terminated, clean up */

		/* this urb is terminated, clean up */

		dbg("%s - urb shutting down with status: %d", __FUNCTION__, urb->status);

		dbg("%s - urb shutting down with status: %d",

		    __FUNCTION__, status);

		return;

		return;

	default:

	default:

		dbg("%s - nonzero urb status received: %d", __FUNCTION__, urb->status);

		dbg("%s - nonzero urb status received: %d",

		    __FUNCTION__, status);

		goto exit;

		goto exit;

	}

	}
@@ -268,10 +271,10 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) 
	}

	}





exit:

exit:

	status = usb_submit_urb (urb, GFP_ATOMIC);

	retval = usb_submit_urb (urb, GFP_ATOMIC);

	if (status)

	if (retval)

		err ("%s - usb_submit_urb failed with result %d",

		err ("%s - usb_submit_urb failed with result %d",

		     __FUNCTION__, status);

		     __FUNCTION__, retval);

}

}