Commit 22f84cce authored Jul 27, 2020 by Tanner Love Committed by Greg Kroah-Hartman Aug 05, 2020

selftests/net: rxtimestamp: fix clang issues for target arch PowerPC



[ Upstream commit 955cbe91bcf782c09afe369c95a20f0a4b6dcc3c ]

The signedness of char is implementation-dependent. Some systems
(including PowerPC and ARM) use unsigned char. Clang 9 threw:
warning: result of comparison of constant -1 with expression of type \
'char' is always true [-Wtautological-constant-out-of-range-compare]
                                  &arg_index)) != -1) {

Tested: make -C tools/testing/selftests TARGETS="net" run_tests

Fixes: 16e78122 ("selftests/net: Add a test to validate behavior of rx timestamps")
Signed-off-by: Tanner Love <tannerlove@google.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 831c904a

tools/testing/selftests/networking/timestamping/rxtimestamp.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -329,8 +329,7 @@ int main(int argc, char **argv)
		bool all_tests = true;
		int arg_index = 0;
		int failures = 0;
		int s, t;
		char opt;
		int s, t, opt;

		while ((opt = getopt_long(argc, argv, "", long_options,
		&arg_index)) != -1) {