Commit 22d67a01 authored Sep 26, 2019 by Denis Efremov Committed by Greg Kroah-Hartman Oct 01, 2019

staging: rtl8188eu: fix HighestRate check in odm_ARFBRefresh_8188E()

It's incorrect to compare HighestRate with 0x0b twice in the following
manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The
"else if" branch is constantly false. The second comparision should be
with 0x03 according to the max_rate_idx in ODM_RAInfo_Init().

Cc: Michael Straube <straube.linux@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Denis Efremov <efremov@linux.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20190926073138.12109-1-efremov@linux.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 955c1532

drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -409,7 +409,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf
		pRaInfo->PTModeSS = 3;
		else if (pRaInfo->HighestRate > 0x0b)
		pRaInfo->PTModeSS = 2;
		else if (pRaInfo->HighestRate > 0x0b)
		else if (pRaInfo->HighestRate > 0x03)
		pRaInfo->PTModeSS = 1;
		else
		pRaInfo->PTModeSS = 0;