Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22b74406 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Vinod Koul
Browse files

dmaengine: idma64: useless use of min_t() 



We use a pattern

	x = min_t(u32, <LOG2_CONSTANT>, __ffs(expr));

There is no need to use min_t() since we can replace it by

	x = __ffs(expr | <2^LOG2_CONST>);

and moreover guarantee that argument of __ffs() will be not zero.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 87b04596

drivers/dma/idma64.c

+2 −2
Original line number Diff line number Diff line
@@ -257,7 +257,7 @@ static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw, 
		dar = config->dst_addr;

		ctllo |= IDMA64C_CTLL_DST_FIX | IDMA64C_CTLL_SRC_INC |

			 IDMA64C_CTLL_FC_M2P;

		src_width = min_t(u32, 2, __ffs(sar | hw->len));

		src_width = __ffs(sar | hw->len | 4);

		dst_width = __ffs(config->dst_addr_width);

	} else {	/* DMA_DEV_TO_MEM */

		sar = config->src_addr;
@@ -265,7 +265,7 @@ static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw, 
		ctllo |= IDMA64C_CTLL_DST_INC | IDMA64C_CTLL_SRC_FIX |

			 IDMA64C_CTLL_FC_P2M;

		src_width = __ffs(config->src_addr_width);

		dst_width = min_t(u32, 2, __ffs(dar | hw->len));

		dst_width = __ffs(dar | hw->len | 4);

	}



	lli->sar = sar;