Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2288b3b3 authored by Yixian Liu's avatar Yixian Liu Committed by Doug Ledford
Browse files

RDMA/hns: Remove unnessary init for cmq reg 



There is no need to init the enable bit of cmq.

Signed-off-by: default avatarYixian Liu <liuyixian@huawei.com>
Link: https://lore.kernel.org/r/1565276034-97329-5-git-send-email-oulijun@huawei.com


Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent ece9c205

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+2 −4
Original line number Diff line number Diff line
@@ -887,8 +887,7 @@ static void hns_roce_cmq_init_regs(struct hns_roce_dev *hr_dev, bool ring_type) 
		roce_write(hr_dev, ROCEE_TX_CMQ_BASEADDR_H_REG,

			   upper_32_bits(dma));

		roce_write(hr_dev, ROCEE_TX_CMQ_DEPTH_REG,

			  (ring->desc_num >> HNS_ROCE_CMQ_DESC_NUM_S) |

			   HNS_ROCE_CMQ_ENABLE);

			   ring->desc_num >> HNS_ROCE_CMQ_DESC_NUM_S);

		roce_write(hr_dev, ROCEE_TX_CMQ_HEAD_REG, 0);

		roce_write(hr_dev, ROCEE_TX_CMQ_TAIL_REG, 0);

	} else {
@@ -896,8 +895,7 @@ static void hns_roce_cmq_init_regs(struct hns_roce_dev *hr_dev, bool ring_type) 
		roce_write(hr_dev, ROCEE_RX_CMQ_BASEADDR_H_REG,

			   upper_32_bits(dma));

		roce_write(hr_dev, ROCEE_RX_CMQ_DEPTH_REG,

			  (ring->desc_num >> HNS_ROCE_CMQ_DESC_NUM_S) |

			   HNS_ROCE_CMQ_ENABLE);

			   ring->desc_num >> HNS_ROCE_CMQ_DESC_NUM_S);

		roce_write(hr_dev, ROCEE_RX_CMQ_HEAD_REG, 0);

		roce_write(hr_dev, ROCEE_RX_CMQ_TAIL_REG, 0);

	}

drivers/infiniband/hw/hns/hns_roce_hw_v2.h

+0 −2
Original line number Diff line number Diff line
@@ -126,8 +126,6 @@ 
#define HNS_ROCE_CMD_FLAG_ERR_INTR	BIT(HNS_ROCE_CMD_FLAG_ERR_INTR_SHIFT)



#define HNS_ROCE_CMQ_DESC_NUM_S		3

#define HNS_ROCE_CMQ_EN_B		16

#define HNS_ROCE_CMQ_ENABLE		BIT(HNS_ROCE_CMQ_EN_B)



#define HNS_ROCE_CMQ_SCC_CLR_DONE_CNT		5