Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2255397c authored by Steve French's avatar Steve French
Browse files

smb3: fix potential null dereference in decrypt offload 



commit a091c5f67c99 ("smb3: allow parallelizing decryption of reads")
had a potential null dereference

Reported-by: default avatarkbuild test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Suggested-by: default avatarPavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 96d9f7ed

fs/cifs/smb2ops.c

+3 −6
Original line number Diff line number Diff line
@@ -4055,6 +4055,7 @@ static void smb2_decrypt_offload(struct work_struct *work) 
		goto free_pages;

	}



	dw->server->lstrp = jiffies;

	mid = smb2_find_mid(dw->server, dw->buf);

	if (mid == NULL)

		cifs_dbg(FYI, "mid not found\n");
@@ -4063,13 +4064,9 @@ static void smb2_decrypt_offload(struct work_struct *work) 
		rc = handle_read_data(dw->server, mid, dw->buf,

				      dw->server->vals->read_rsp_size,

				      dw->ppages, dw->npages, dw->len);

	}



	dw->server->lstrp = jiffies;



		mid->callback(mid);



		cifs_mid_q_entry_release(mid);

	}



free_pages:

	for (i = dw->npages-1; i >= 0; i--)