Commit 2226ad03 authored Sep 29, 2021 by Kees Cook Committed by Greg Kroah-Hartman Nov 17, 2021

leaking_addresses: Always print a trailing newline

[ Upstream commit cf2a85efdade117e2169d6e26641016cbbf03ef0 ]

For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/



Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211008111626.151570317@infradead.org


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 63c3c7b6

scripts/leaking_addresses.pl

+2 −1

Original line number	Diff line number	Diff line
		@@ -455,8 +455,9 @@ sub parse_file

		open my $fh, "<", $file or return;
		while ( <$fh> ) {
		chomp;
		if (may_leak_address($_)) {
		print $file . ': ' . $_;
		printf("$file: $_\n");
		}
		}
		close $fh;