Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 213d7767 authored by Yafang Shao's avatar Yafang Shao Committed by David S. Miller
Browse files

tcp: clean up STATE_TRACE 



Currently we can use bpf or tcp tracepoint to conveniently trace the tcp
state transition at the run time.
So we don't need to do this stuff at the compile time anymore.

Signed-off-by: default avatarYafang Shao <laoar.shao@gmail.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e119a369

include/net/tcp.h

+0 −12
Original line number Diff line number Diff line
@@ -1323,20 +1323,8 @@ static inline bool tcp_checksum_complete(struct sk_buff *skb) 


bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb);

int tcp_filter(struct sock *sk, struct sk_buff *skb);



#undef STATE_TRACE



#ifdef STATE_TRACE

static const char *statename[]={

	"Unused","Established","Syn Sent","Syn Recv",

	"Fin Wait 1","Fin Wait 2","Time Wait", "Close",

	"Close Wait","Last ACK","Listen","Closing"

};

#endif

void tcp_set_state(struct sock *sk, int state);



void tcp_done(struct sock *sk);



int tcp_abort(struct sock *sk, int err);



static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)

net/ipv4/tcp.c

+0 −4
Original line number Diff line number Diff line
@@ -2241,10 +2241,6 @@ void tcp_set_state(struct sock *sk, int state) 
	 * socket sitting in hash tables.

	 */

	inet_sk_state_store(sk, state);



#ifdef STATE_TRACE

	SOCK_DEBUG(sk, "TCP sk=%p, State %s -> %s\n", sk, statename[oldstate], statename[state]);

#endif

}

EXPORT_SYMBOL_GPL(tcp_set_state);