Commit 20c63f40 authored Feb 12, 2018 by Stefan Agner Committed by Felipe Balbi Feb 12, 2018

usb: gadget: fsl_udc_core: fix ep valid checks



Clang reports the following warning:
  drivers/usb/gadget/udc/fsl_udc_core.c:1312:10: warning: address of array
  'ep->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (ep->name)
        ~~  ~~~~^~~~

It seems that the authors intention was to check if the ep has been
configured through struct_ep_setup. Check whether struct usb_ep name
pointer has been set instead.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 17aa31f1

drivers/usb/gadget/udc/fsl_udc_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1305,7 +1305,7 @@ static void udc_reset_ep_queue(struct fsl_udc *udc, u8 pipe)
		{
		struct fsl_ep *ep = get_ep_by_pipe(udc, pipe);

		if (ep->name)
		if (ep->ep.name)
		nuke(ep, -ESHUTDOWN);
		}

		@@ -1693,7 +1693,7 @@ static void dtd_complete_irq(struct fsl_udc *udc)
		curr_ep = get_ep_by_pipe(udc, i);

		/* If the ep is configured */
		if (curr_ep->name == NULL) {
		if (!curr_ep->ep.name) {
		WARNING("Invalid EP?");
		continue;
		}