Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20b7af41 authored by Ido Schimmel's avatar Ido Schimmel Committed by Greg Kroah-Hartman
Browse files

ipv6_tunnel: Rate limit warning messages 



commit 6cee105e7f2ced596373951d9ea08dacc3883c68 upstream.

The warning messages can be invoked from the data path for every packet
transmitted through an ip6gre netdev, leading to high CPU utilization.

Fix that by rate limiting the messages.

Fixes: 09c6bbf0 ("[IPV6]: Do mandatory IPv6 tunnel endpoint checks in realtime")
Reported-by: default avatarMaksym Yaremchuk <maksymy@nvidia.com>
Tested-by: default avatarMaksym Yaremchuk <maksymy@nvidia.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarAmit Cohen <amcohen@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bf2bd892

net/ipv6/ip6_tunnel.c

+4 −4
Original line number Diff line number Diff line
@@ -1000,13 +1000,13 @@ int ip6_tnl_xmit_ctl(struct ip6_tnl *t, 


		if (unlikely(!ipv6_chk_addr_and_flags(net, laddr, ldev, false,

						      0, IFA_F_TENTATIVE)))

			pr_warn("%s xmit: Local address not yet configured!\n",

			pr_warn_ratelimited("%s xmit: Local address not yet configured!\n",

					    p->name);

		else if (!(p->flags & IP6_TNL_F_ALLOW_LOCAL_REMOTE) &&

			 !ipv6_addr_is_multicast(raddr) &&

			 unlikely(ipv6_chk_addr_and_flags(net, raddr, ldev,

							  true, 0, IFA_F_TENTATIVE)))

			pr_warn("%s xmit: Routing loop! Remote address found on this node!\n",

			pr_warn_ratelimited("%s xmit: Routing loop! Remote address found on this node!\n",

					    p->name);

		else

			ret = 1;