Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20aa787e authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: ti_am335x_tsc - use SIMPLE_DEV_PM_OPS 



Instead of doing the dance with macro that either resolves to a pointer or
NULL, let's switch to using SIMPLE_DEV_PM_OPS().

Also let's mark suspend and resume methods as __maybe_unused instead of
guarding them with an #ifdef and rely on linker to drop unused code. Doing
so should allow better compile coverage.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent b5ca3ea3

drivers/input/touchscreen/ti_am335x_tsc.c

+4 −12
Original line number Diff line number Diff line
@@ -487,8 +487,7 @@ static int titsc_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM

static int titsc_suspend(struct device *dev)

static int __maybe_unused titsc_suspend(struct device *dev)

{

	struct titsc *ts_dev = dev_get_drvdata(dev);

	struct ti_tscadc_dev *tscadc_dev;
@@ -504,7 +503,7 @@ static int titsc_suspend(struct device *dev) 
	return 0;

}



static int titsc_resume(struct device *dev)

static int __maybe_unused titsc_resume(struct device *dev)

{

	struct titsc *ts_dev = dev_get_drvdata(dev);

	struct ti_tscadc_dev *tscadc_dev;
@@ -521,14 +520,7 @@ static int titsc_resume(struct device *dev) 
	return 0;

}



static const struct dev_pm_ops titsc_pm_ops = {

	.suspend = titsc_suspend,

	.resume  = titsc_resume,

};

#define TITSC_PM_OPS (&titsc_pm_ops)

#else

#define TITSC_PM_OPS NULL

#endif

static SIMPLE_DEV_PM_OPS(titsc_pm_ops, titsc_suspend, titsc_resume);



static const struct of_device_id ti_tsc_dt_ids[] = {

	{ .compatible = "ti,am3359-tsc", },
@@ -541,7 +533,7 @@ static struct platform_driver ti_tsc_driver = { 
	.remove	= titsc_remove,

	.driver	= {

		.name   = "TI-am335x-tsc",

		.pm	= TITSC_PM_OPS,

		.pm	= &titsc_pm_ops,

		.of_match_table = ti_tsc_dt_ids,

	},

};