Commit 2050d14c authored Dec 28, 2015 by Markus Elfring Committed by Mauro Carvalho Chehab Jan 25, 2016

[media] tuners: Refactoring for m88rs6000t_sleep()



This issue was detected by using the Coccinelle software.

1. Let us return directly if a call of the regmap_write() function failed.

2. Delete the jump label "err" then.

3. Return zero as a constant at the end.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent c2e5c951

drivers/media/tuners/m88rs6000t.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -461,14 +461,13 @@ static int m88rs6000t_sleep(struct dvb_frontend *fe)
		dev_dbg(&dev->client->dev, "%s:\n", __func__);

		ret = regmap_write(dev->regmap, 0x07, 0x6d);
		if (ret)
		goto err;
		usleep_range(5000, 10000);
		err:
		if (ret)
		if (ret) {
		dev_dbg(&dev->client->dev, "failed=%d\n", ret);
		return ret;
		}
		usleep_range(5000, 10000);
		return 0;
		}

		static int m88rs6000t_get_frequency(struct dvb_frontend fe, u32 frequency)
		{