Commit 204beeb5 authored Sep 21, 2023 by Dinghao Liu Committed by Greg Kroah-Hartman Nov 20, 2023

i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs



[ Upstream commit cab63f64887616e3c4e31cfd8103320be6ebc8d3 ]

put_device() needs to be called on failure of device_register()
to give up the reference initialized in it to avoid refcount leak.

Fixes: 3a379bbc ("i3c: Add core I3C infrastructure")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn


Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 247ed618

drivers/i3c/master.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1469,9 +1469,11 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master)
		desc->dev->dev.of_node = desc->boardinfo->of_node;

		ret = device_register(&desc->dev->dev);
		if (ret)
		if (ret) {
		dev_err(&master->dev,
		"Failed to add I3C device (err = %d)\n", ret);
		put_device(&desc->dev->dev);
		}
		}
		}