Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ffba626 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/providers: Remove pointless functions 



The rdma core is taking care of return the right error code when the
rdma device callbacks aren't supported.

Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Acked-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 0584c47b

drivers/infiniband/hw/cxgb3/iwch_provider.c

+0 −41
Original line number Original line Diff line number Diff line
@@ -61,42 +61,6 @@ 
#include <rdma/cxgb3-abi.h>

#include <rdma/cxgb3-abi.h>

#include "common.h"

#include "common.h"





static struct ib_ah *iwch_ah_create(struct ib_pd *pd,

				    struct rdma_ah_attr *ah_attr,

				    struct ib_udata *udata)

{

	return ERR_PTR(-ENOSYS);

}



static int iwch_ah_destroy(struct ib_ah *ah)

{

	return -ENOSYS;

}



static int iwch_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)

{

	return -ENOSYS;

}



static int iwch_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)

{

	return -ENOSYS;

}



static int iwch_process_mad(struct ib_device *ibdev,

			    int mad_flags,

			    u8 port_num,

			    const struct ib_wc *in_wc,

			    const struct ib_grh *in_grh,

			    const struct ib_mad_hdr *in_mad,

			    size_t in_mad_size,

			    struct ib_mad_hdr *out_mad,

			    size_t *out_mad_size,

			    u16 *out_mad_pkey_index)

{

	return -ENOSYS;

}



static int iwch_dealloc_ucontext(struct ib_ucontext *context)

static int iwch_dealloc_ucontext(struct ib_ucontext *context)

{

{

	struct iwch_dev *rhp = to_iwch_dev(context->device);

	struct iwch_dev *rhp = to_iwch_dev(context->device);
@@ -1399,8 +1363,6 @@ int iwch_register_device(struct iwch_dev *dev) 
	dev->ibdev.mmap = iwch_mmap;

	dev->ibdev.mmap = iwch_mmap;

	dev->ibdev.alloc_pd = iwch_allocate_pd;

	dev->ibdev.alloc_pd = iwch_allocate_pd;

	dev->ibdev.dealloc_pd = iwch_deallocate_pd;

	dev->ibdev.dealloc_pd = iwch_deallocate_pd;

	dev->ibdev.create_ah = iwch_ah_create;

	dev->ibdev.destroy_ah = iwch_ah_destroy;

	dev->ibdev.create_qp = iwch_create_qp;

	dev->ibdev.create_qp = iwch_create_qp;

	dev->ibdev.modify_qp = iwch_ib_modify_qp;

	dev->ibdev.modify_qp = iwch_ib_modify_qp;

	dev->ibdev.destroy_qp = iwch_destroy_qp;

	dev->ibdev.destroy_qp = iwch_destroy_qp;
@@ -1415,9 +1377,6 @@ int iwch_register_device(struct iwch_dev *dev) 
	dev->ibdev.dealloc_mw = iwch_dealloc_mw;

	dev->ibdev.dealloc_mw = iwch_dealloc_mw;

	dev->ibdev.alloc_mr = iwch_alloc_mr;

	dev->ibdev.alloc_mr = iwch_alloc_mr;

	dev->ibdev.map_mr_sg = iwch_map_mr_sg;

	dev->ibdev.map_mr_sg = iwch_map_mr_sg;

	dev->ibdev.attach_mcast = iwch_multicast_attach;

	dev->ibdev.detach_mcast = iwch_multicast_detach;

	dev->ibdev.process_mad = iwch_process_mad;

	dev->ibdev.req_notify_cq = iwch_arm_cq;

	dev->ibdev.req_notify_cq = iwch_arm_cq;

	dev->ibdev.post_send = iwch_post_send;

	dev->ibdev.post_send = iwch_post_send;

	dev->ibdev.post_recv = iwch_post_receive;

	dev->ibdev.post_recv = iwch_post_receive;

drivers/infiniband/hw/cxgb4/cq.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -1140,11 +1140,6 @@ struct ib_cq *c4iw_create_cq(struct ib_device *ibdev, 
	return ERR_PTR(ret);

	return ERR_PTR(ret);

}

}





int c4iw_resize_cq(struct ib_cq *cq, int cqe, struct ib_udata *udata)

{

	return -ENOSYS;

}



int c4iw_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)

int c4iw_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)

{

{

	struct c4iw_cq *chp;

	struct c4iw_cq *chp;

drivers/infiniband/hw/cxgb4/iw_cxgb4.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -1063,7 +1063,6 @@ struct ib_cq *c4iw_create_cq(struct ib_device *ibdev, 
			     const struct ib_cq_init_attr *attr,

			     const struct ib_cq_init_attr *attr,

			     struct ib_ucontext *ib_context,

			     struct ib_ucontext *ib_context,

			     struct ib_udata *udata);

			     struct ib_udata *udata);

int c4iw_resize_cq(struct ib_cq *cq, int cqe, struct ib_udata *udata);

int c4iw_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags);

int c4iw_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags);

int c4iw_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *attr,

int c4iw_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *attr,

		    enum ib_srq_attr_mask srq_attr_mask,

		    enum ib_srq_attr_mask srq_attr_mask,

drivers/infiniband/hw/cxgb4/provider.c

+0 −41
Original line number Original line Diff line number Diff line
@@ -58,41 +58,6 @@ static int fastreg_support = 1; 
module_param(fastreg_support, int, 0644);

module_param(fastreg_support, int, 0644);

MODULE_PARM_DESC(fastreg_support, "Advertise fastreg support (default=1)");

MODULE_PARM_DESC(fastreg_support, "Advertise fastreg support (default=1)");





static struct ib_ah *c4iw_ah_create(struct ib_pd *pd,

				    struct rdma_ah_attr *ah_attr,

				    struct ib_udata *udata)



{

	return ERR_PTR(-ENOSYS);

}



static int c4iw_ah_destroy(struct ib_ah *ah)

{

	return -ENOSYS;

}



static int c4iw_multicast_attach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)

{

	return -ENOSYS;

}



static int c4iw_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)

{

	return -ENOSYS;

}



static int c4iw_process_mad(struct ib_device *ibdev, int mad_flags,

			    u8 port_num, const struct ib_wc *in_wc,

			    const struct ib_grh *in_grh,

			    const struct ib_mad_hdr *in_mad,

			    size_t in_mad_size,

			    struct ib_mad_hdr *out_mad,

			    size_t *out_mad_size,

			    u16 *out_mad_pkey_index)

{

	return -ENOSYS;

}



void _c4iw_free_ucontext(struct kref *kref)

void _c4iw_free_ucontext(struct kref *kref)

{

{

	struct c4iw_ucontext *ucontext;

	struct c4iw_ucontext *ucontext;
@@ -615,8 +580,6 @@ void c4iw_register_device(struct work_struct *work) 
	dev->ibdev.mmap = c4iw_mmap;

	dev->ibdev.mmap = c4iw_mmap;

	dev->ibdev.alloc_pd = c4iw_allocate_pd;

	dev->ibdev.alloc_pd = c4iw_allocate_pd;

	dev->ibdev.dealloc_pd = c4iw_deallocate_pd;

	dev->ibdev.dealloc_pd = c4iw_deallocate_pd;

	dev->ibdev.create_ah = c4iw_ah_create;

	dev->ibdev.destroy_ah = c4iw_ah_destroy;

	dev->ibdev.create_qp = c4iw_create_qp;

	dev->ibdev.create_qp = c4iw_create_qp;

	dev->ibdev.modify_qp = c4iw_ib_modify_qp;

	dev->ibdev.modify_qp = c4iw_ib_modify_qp;

	dev->ibdev.query_qp = c4iw_ib_query_qp;

	dev->ibdev.query_qp = c4iw_ib_query_qp;
@@ -626,7 +589,6 @@ void c4iw_register_device(struct work_struct *work) 
	dev->ibdev.destroy_srq = c4iw_destroy_srq;

	dev->ibdev.destroy_srq = c4iw_destroy_srq;

	dev->ibdev.create_cq = c4iw_create_cq;

	dev->ibdev.create_cq = c4iw_create_cq;

	dev->ibdev.destroy_cq = c4iw_destroy_cq;

	dev->ibdev.destroy_cq = c4iw_destroy_cq;

	dev->ibdev.resize_cq = c4iw_resize_cq;

	dev->ibdev.poll_cq = c4iw_poll_cq;

	dev->ibdev.poll_cq = c4iw_poll_cq;

	dev->ibdev.get_dma_mr = c4iw_get_dma_mr;

	dev->ibdev.get_dma_mr = c4iw_get_dma_mr;

	dev->ibdev.reg_user_mr = c4iw_reg_user_mr;

	dev->ibdev.reg_user_mr = c4iw_reg_user_mr;
@@ -635,9 +597,6 @@ void c4iw_register_device(struct work_struct *work) 
	dev->ibdev.dealloc_mw = c4iw_dealloc_mw;

	dev->ibdev.dealloc_mw = c4iw_dealloc_mw;

	dev->ibdev.alloc_mr = c4iw_alloc_mr;

	dev->ibdev.alloc_mr = c4iw_alloc_mr;

	dev->ibdev.map_mr_sg = c4iw_map_mr_sg;

	dev->ibdev.map_mr_sg = c4iw_map_mr_sg;

	dev->ibdev.attach_mcast = c4iw_multicast_attach;

	dev->ibdev.detach_mcast = c4iw_multicast_detach;

	dev->ibdev.process_mad = c4iw_process_mad;

	dev->ibdev.req_notify_cq = c4iw_arm_cq;

	dev->ibdev.req_notify_cq = c4iw_arm_cq;

	dev->ibdev.post_send = c4iw_post_send;

	dev->ibdev.post_send = c4iw_post_send;

	dev->ibdev.post_recv = c4iw_post_receive;

	dev->ibdev.post_recv = c4iw_post_receive;

drivers/infiniband/hw/i40iw/i40iw_verbs.c

+0 −40
Original line number Original line Diff line number Diff line
@@ -2702,21 +2702,6 @@ static int i40iw_query_gid(struct ib_device *ibdev, 
	return 0;

	return 0;

}

}





/**

 * i40iw_modify_port  Modify port properties

 * @ibdev: device pointer from stack

 * @port: port number

 * @port_modify_mask: mask for port modifications

 * @props: port properties

 */

static int i40iw_modify_port(struct ib_device *ibdev,

			     u8 port,

			     int port_modify_mask,

			     struct ib_port_modify *props)

{

	return -ENOSYS;

}



/**

/**

 * i40iw_query_pkey - Query partition key

 * i40iw_query_pkey - Query partition key

 * @ibdev: device pointer from stack

 * @ibdev: device pointer from stack
@@ -2733,28 +2718,6 @@ static int i40iw_query_pkey(struct ib_device *ibdev, 
	return 0;

	return 0;

}

}





/**

 * i40iw_create_ah - create address handle

 * @ibpd: ptr of pd

 * @ah_attr: address handle attributes

 */

static struct ib_ah *i40iw_create_ah(struct ib_pd *ibpd,

				     struct rdma_ah_attr *attr,

				     struct ib_udata *udata)



{

	return ERR_PTR(-ENOSYS);

}



/**

 * i40iw_destroy_ah - Destroy address handle

 * @ah: pointer to address handle

 */

static int i40iw_destroy_ah(struct ib_ah *ah)

{

	return -ENOSYS;

}



/**

/**

 * i40iw_get_vector_affinity - report IRQ affinity mask

 * i40iw_get_vector_affinity - report IRQ affinity mask

 * @ibdev: IB device

 * @ibdev: IB device
@@ -2822,7 +2785,6 @@ static struct i40iw_ib_device *i40iw_init_rdma_device(struct i40iw_device *iwdev 
	iwibdev->ibdev.num_comp_vectors = iwdev->ceqs_count;

	iwibdev->ibdev.num_comp_vectors = iwdev->ceqs_count;

	iwibdev->ibdev.dev.parent = &pcidev->dev;

	iwibdev->ibdev.dev.parent = &pcidev->dev;

	iwibdev->ibdev.query_port = i40iw_query_port;

	iwibdev->ibdev.query_port = i40iw_query_port;

	iwibdev->ibdev.modify_port = i40iw_modify_port;

	iwibdev->ibdev.query_pkey = i40iw_query_pkey;

	iwibdev->ibdev.query_pkey = i40iw_query_pkey;

	iwibdev->ibdev.query_gid = i40iw_query_gid;

	iwibdev->ibdev.query_gid = i40iw_query_gid;

	iwibdev->ibdev.alloc_ucontext = i40iw_alloc_ucontext;

	iwibdev->ibdev.alloc_ucontext = i40iw_alloc_ucontext;
@@ -2842,8 +2804,6 @@ static struct i40iw_ib_device *i40iw_init_rdma_device(struct i40iw_device *iwdev 
	iwibdev->ibdev.alloc_hw_stats = i40iw_alloc_hw_stats;

	iwibdev->ibdev.alloc_hw_stats = i40iw_alloc_hw_stats;

	iwibdev->ibdev.get_hw_stats = i40iw_get_hw_stats;

	iwibdev->ibdev.get_hw_stats = i40iw_get_hw_stats;

	iwibdev->ibdev.query_device = i40iw_query_device;

	iwibdev->ibdev.query_device = i40iw_query_device;

	iwibdev->ibdev.create_ah = i40iw_create_ah;

	iwibdev->ibdev.destroy_ah = i40iw_destroy_ah;

	iwibdev->ibdev.drain_sq = i40iw_drain_sq;

	iwibdev->ibdev.drain_sq = i40iw_drain_sq;

	iwibdev->ibdev.drain_rq = i40iw_drain_rq;

	iwibdev->ibdev.drain_rq = i40iw_drain_rq;

	iwibdev->ibdev.alloc_mr = i40iw_alloc_mr;

	iwibdev->ibdev.alloc_mr = i40iw_alloc_mr;