Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fb5f68a authored by Markos Chandras's avatar Markos Chandras Committed by Chris Ball
Browse files

mmc: dw_mmc: Don't loop when handling an interrupt 



There is no reason to loop when handling an interrupt. The "if" clauses
will handle all of them sequentially. This also eliminates the extra loop
we used to take with no pending interrupts and we ended up breaking out
of the while loop.

Signed-off-by: default avatarMarkos Chandras <markos.chandras@imgtec.com>
Acked-by: default avatarJaehoon Chung <jh80.chung@samsung.com>
Acked-by: default avatarSeungwon Jeon <tgih.jun@samsung.com>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent 63008768

drivers/mmc/host/dw_mmc.c

+4 −7
Original line number Diff line number Diff line
@@ -1573,12 +1573,12 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) 
{

	struct dw_mci *host = dev_id;

	u32 pending;

	unsigned int pass_count = 0;

	int i;



	do {

	pending = mci_readl(host, MINTSTS); /* read-only mask reg */



	if (pending) {



		/*

		 * DTO fix - version 2.10a and below, and only if internal DMA

		 * is configured.
@@ -1589,9 +1589,6 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) 
				pending |= SDMMC_INT_DATA_OVER;

		}



		if (!pending)

			break;



		if (pending & DW_MCI_CMD_ERROR_FLAGS) {

			mci_writel(host, RINTSTS, DW_MCI_CMD_ERROR_FLAGS);

			host->cmd_status = pending;
@@ -1652,7 +1649,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) 
			}

		}



	} while (pass_count++ < 5);

	}



#ifdef CONFIG_MMC_DW_IDMAC

	/* Handle DMA interrupts */