Commit 1f5e6fdd authored Apr 10, 2019 by Paolo Abeni Committed by David S. Miller Apr 10, 2019

net: sched: prefer qdisc_is_empty() over direct qlen access



When checking for root qdisc queue length, do not access directly q.qlen.
In the following patches we will move back qlen accounting to per CPU
values for NOLOCK qdiscs.

Instead, prefer the qdisc_is_empty() helper usage.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b0a231a2

include/net/sch_generic.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -747,7 +747,7 @@ static inline bool qdisc_all_tx_empty(const struct net_device *dev)
		struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
		const struct Qdisc *q = rcu_dereference(txq->qdisc);

		if (q->q.qlen) {
		if (!qdisc_is_empty(q)) {
		rcu_read_unlock();
		return false;
		}