Commit 1ecf0d0c authored Apr 28, 2008 by Roel Kluin Committed by Linus Torvalds Apr 28, 2008

dz: test after postfix decrement fails in dz_console_putchar()

When loops reaches 0 the postfix decrement still subtracts, so the subsequent
test fails.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Johannes Weiner <hannes@saeurebad.de>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 556637cd

drivers/serial/dz.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -819,7 +819,7 @@ static void dz_console_putchar(struct uart_port *uport, int ch)
		dz_out(dport, DZ_TCR, mask);
		iob();
		udelay(2);
		} while (loops--);
		} while (--loops);

		if (loops) /* Cannot send otherwise. */
		dz_out(dport, DZ_TDR, ch);