Commit 1ec9b0af authored Nov 09, 2017 by Colin Ian King Committed by Alex Deucher Nov 09, 2017

drm/amd/powerplay: fix copy-n-paste error on vddci_buf index

The index to vddci_buf is using profile->ucElbVDDC_Num rather
than profile->ucElbVDDCI_Num; this looks like a copy-n-paste
error from previous code for the vddc_buf array and I'm pretty
sure this is incorrect. Fix this by using the correct variable.

Detected by CoverityScan, CID#1457172 ("Copy-paste error")

Fixes: 970d9804 ("drm/amd/powerplay: Add support functions for CI to ppatomctrl.c")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent cdadab89

drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1486,7 +1486,7 @@ int atomctrl_get_leakage_vddc_base_on_leakage(struct pp_hwmgr *hwmgr,
	if (vddci_id_buf[i] == virtual_voltage_id) {		if (vddci_id_buf[i] == virtual_voltage_id) {
	for (j = 0; j < profile->ucLeakageBinNum; j++) {		for (j = 0; j < profile->ucLeakageBinNum; j++) {
	if (efuse_voltage_id <= leakage_bin[j]) {		if (efuse_voltage_id <= leakage_bin[j]) {
	vddci = vddci_buf[j profile->ucElbVDDC_Num + i];		vddci = vddci_buf[j profile->ucElbVDDCI_Num + i];
	break;		break;
	}		}
	}		}