Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1dd2058f authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki
Browse files

cpufreq: qcom-kryo: Fix error handling in probe() 



We should return if get_cpu_device() fails or it leads to a NULL
dereference.  Also dev_pm_opp_of_get_opp_desc_node() returns NULL on
error, it never returns error pointers.

Fixes: 46e2856b (cpufreq: Add Kryo CPU scaling driver)
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 7daf201d

drivers/cpufreq/qcom-cpufreq-kryo.c

+4 −4
Original line number Diff line number Diff line
@@ -87,8 +87,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev) 
	int ret;



	cpu_dev = get_cpu_device(0);

	if (NULL == cpu_dev)

		ret = -ENODEV;

	if (!cpu_dev)

		return -ENODEV;



	msm8996_version = qcom_cpufreq_kryo_get_msm_id();

	if (NUM_OF_MSM8996_VERSIONS == msm8996_version) {
@@ -97,8 +97,8 @@ static int qcom_cpufreq_kryo_probe(struct platform_device *pdev) 
	}



	np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);

	if (IS_ERR(np))

		return PTR_ERR(np);

	if (!np)

		return -ENOENT;



	ret = of_device_is_compatible(np, "operating-points-v2-kryo-cpu");

	if (!ret) {