Commit 1d463956 authored Nov 11, 2019 by YueHaibing Committed by David S. Miller Nov 11, 2019

mdio_bus: Fix PTR_ERR applied after initialization to constant



Fix coccinelle warning:

./drivers/net/phy/mdio_bus.c:67:5-12: ERROR: PTR_ERR applied after initialization to constant on line 62
./drivers/net/phy/mdio_bus.c:68:5-12: ERROR: PTR_ERR applied after initialization to constant on line 62

Fix this by using IS_ERR before PTR_ERR

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 71dd6c0d ("net: phy: add support for reset-controller")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a71a29f5

drivers/net/phy/mdio_bus.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -64,11 +64,12 @@ static int mdiobus_register_reset(struct mdio_device *mdiodev)
		if (mdiodev->dev.of_node)
		reset = devm_reset_control_get_exclusive(&mdiodev->dev,
		"phy");
		if (PTR_ERR(reset) == -ENOENT \|\|
		PTR_ERR(reset) == -ENOTSUPP)
		if (IS_ERR(reset)) {
		if (PTR_ERR(reset) == -ENOENT \|\| PTR_ERR(reset) == -ENOSYS)
		reset = NULL;
		else if (IS_ERR(reset))
		else
		return PTR_ERR(reset);
		}

		mdiodev->reset_ctrl = reset;