Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d3ff095 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

dccp: Fix memleak in __feat_register_sp 



If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Fixes: e8ef967a ("dccp: Registration routines for changing feature values")
Reviewed-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 09279e61

net/dccp/feat.c

+6 −1
Original line number Diff line number Diff line
@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local, 
	if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))

		return -ENOMEM;



	return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);

	if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {

		kfree(fval.sp.vec);

		return -ENOMEM;

	}



	return 0;

}



/**